update wasmVM to v1.4.0 #4603
update wasmVM to v1.4.0 #4603
Conversation
faddat
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
This reverts commit b57444b.
…sm' into faddat/update-wasmvm
TestInitializeTendermint(), remove unnecessary test from TestConsensusStateValidateBasic(), change the update state result's height type.
TestStatusGrandpa, and TestExportGenesisGrandpa working again
TestUpdateStateGrandpa, TestVerifyUpgradeGrandpa working again
| ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.4.0/libwasmvm_muslc.aarch64.a /lib/libwasmvm_muslc.aarch64.a | ||
| ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.4.0/libwasmvm_muslc.x86_64.a /lib/libwasmvm_muslc.x86_64.a | ||
| RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep 2a72c7062e3c791792b3dab781c815c9a76083a7997ce6f9f2799aaf577f3c25 | ||
| RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep 8ea2e3b5fae83e671da2bb51115adc88591045953f509955ec38dc02ea5a7b94 |
There was a problem hiding this comment.
looks like we need to update the modules/light-clients/08-wasm/Dockerfile instead. But there's no harm actually just updating both for now.
There was a problem hiding this comment.
hopefully in the call today we'll be able to clean up the dep we currently have on 08-wasm in ibc-go. when that's done, a couple of things will be able to be removed including these changes to the Dockerfile
There was a problem hiding this comment.
we also wouldn't need to get the aarch64 lib? We should only be running actual tests on x86_64 machine.
|
looks like the feature branch got updated when it was bumped to v0.50 https://github.com/cosmos/ibc-go/blob/feat/wasm-clients/modules/light-clients/08-wasm/go.mod#L22, so I think we can close this pr? |
|
@colin-axner we still need the bump of the wasmvm static lib. this should be easier to do in a separate PR. Closing this and will open PR bumping wasmvm (#4834). Thanks @faddat! |
Description
WasmVM has updated to a much newer version of wasmer, which should bring greatly improved performance.
This PR updates wasmvm to v1.4.0, which updates wasmer from the v2.0.x series to the v4.0.x series of wasmer.
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Attribution
@misko9 made meaningful contributions to this PR that ensured that tests pass. This is the case for all PR's linked to issue #4612
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.